Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bad readability issue of Include Timestamp #1401

Conversation

SebiWrn
Copy link
Collaborator

@SebiWrn SebiWrn commented Nov 10, 2024

Motivation and Context

This PR fixes Issue #1167

Description

There is now a new class called important-text-4 which adds the !important flag to the text color.
Can be used to override text colors of other selectors, use with caution!.

Steps for Testing

  1. Navigate to any VoD
  2. Press the Share Button
  3. Select Include Timestamp

Copy link

Your Testserver will be ready at https://1401.test.live.mm.rbg.tum.de in a few minutes.

Logins
Kurs1 Kurs2 Kurs3 Kurs4
public public loggedin enrolled
prof1 prof1 prof2 prof1
prof2
student1
student2
student3
student1
student2
student2
student3
student1
student2

@joschahenningsen
Copy link
Member

You can, btw, request reviews from @TUM-Dev/tum-live to ping all members

@joschahenningsen joschahenningsen merged commit 7364d47 into dev Nov 10, 2024
8 of 9 checks passed
@joschahenningsen joschahenningsen deleted the 1167-include-timestamp-text-in-share-dialogue-hardly-readable-in-dark-mode branch November 10, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Include Timestamp" text in share dialogue hardly readable in dark mode
2 participants